Merged
Conversation
LAN9730 utilizes LWIP when LWIP exists. Signed-off-by: Siwei Zhuang <[email protected]>
Member
|
So did this never compile before at all? I wonder, what is the actual dependency there, that the driver need to know about the higher layer protocols? |
Contributor
Author
|
It never compiled with lwip turned on. We're reviving some legacy code which happens to use both lwip and usb. |
Member
|
Change seem ok to me if this make it build again. Looks like this is another thing around improving GitHub CI coverage, see seL4/util_libs#112 (comment) and seL4/camkes#13 |
axel-h
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LAN9730 utilizes LWIP when LWIP exists.
Signed-off-by: Siwei Zhuang [email protected]