Disallow unsupported TLSv1.3 socket options #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Maria-12648430 thanks, I haven't had time to finish testing changes as per our discussion on ninenines#313. I was trying to implement the changes requested in the comments, but it's been quite busy. |
adrigonzo
reviewed
Jun 2, 2021
src/ranch_ssl.erl
Outdated
| end. | ||
|
|
||
| get_tls_versions_env() -> | ||
| case application:get_env(ssl, protocol_versions) of |
There was a problem hiding this comment.
I think is is called protocol_version in the env.
Maria-12648430
force-pushed
the
se-apc/fix_tlsv1.3_improved
branch
from
2c4621e to
d2fb8d0
Compare
Author
Reminds me, tests will probably be required for this, also =^^= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adrigonzo I noticed your PR in
ranchfor this branch died down.I guess there is interest in it, though, but I don't want to steal your PR. So... allow me to give you a hand here? =^^=
Regards, Maria 😊