Dc ttl not equal zero #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metelik
requested changes
Oct 3, 2025
metelik
left a comment
metelik
left a comment
There was a problem hiding this comment.
The check should be done in Network_Port_FD_Subscription_Lifetime_Write function @ 'if (value > UINT16_MAX) {' condition check .
edit the wrong IPv4 function FDR TTL no longer accepts 0 removed wrong setting within a function removed to much there spacing forget to remove if statement removed individual function check for 0 and added a single check
dcmaverick
force-pushed
the
dc_TTL_not_equal_zero
branch
from
0aefdfe to
8fc937a
Compare
adrigonzo
approved these changes
Oct 6, 2025
metelik
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FDR TTL shouldn't allow "0" , now it doesn't.
JIRA:
https://jira.se.com/browse/FIRMWARE-30411