chore: version upgrades (Gradle and jreleaser plugin)#1477
Open
dejan2609 wants to merge 1 commit intosdkman:masterfrom
Open
chore: version upgrades (Gradle and jreleaser plugin)#1477dejan2609 wants to merge 1 commit intosdkman:masterfrom
dejan2609 wants to merge 1 commit intosdkman:masterfrom
Conversation
details: - Gradle: 8.0.1 -->> 8.14.3 - 'org.jreleaser' plugin: 1.4.0 -->> 1.20.0
marc0der
reviewed
Oct 27, 2025
Member
marc0der
left a comment
marc0der
left a comment
There was a problem hiding this comment.
Hi, thanks for your PR. I just have the one comment but I'll happily merge if you address that.
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env sh | |||
| #!/bin/sh | |||
Member
There was a problem hiding this comment.
I realise that this is a generated script, but this is a regression that will cause many systems to break. The modern trend is to delegate to env to set the shell.
Author
There was a problem hiding this comment.
I was under the impression that Gradle had already solved that.
Let me try to investigate, I'll get back to this eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
details:
[ ℹ️ ] test coverage was not added (not applicable for this PR)
Fixes #1476