-
Notifications
You must be signed in to change notification settings - Fork 65
Retry link checking with backoff #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you adding all this code instead of using something pre-made?
https://will-ockmore.github.io/httpx-retries/
also we should just reuse a session instead of always touching every single place we use httpx every time we change something, right?
|
It was simple enough that I didn't bother searching. |
|
You have a stronger stomach than I do if you consider anything HTTP related simple. There are always so many edge cases that I just want to play lego with blocks built by people who really understand all the layers and pieces instead of rolling my own. |
|
That's fair, but the worst thing that can happen here is a CI job failing |
|
Of course! Still, less complexity to maintain is good, right? |
|
Great, thank you! I just moved all the repeated |
Found myself restarting a job too often because a random site didn't respond on time