Revert "Fix relative worker path for non-root deployments"#862
Merged
Revert "Fix relative worker path for non-root deployments"#862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Reverts #786
Reason for Changes
Unfortunately, this change broke asset loading when the editor is loaded into
scratch-www. I'm reverting it as a "quick fix," but I could see bringing it back if we find a way to make it work correctly in the context ofscratch-www. Ideally, I'd like to come up with a test that fails withscratch-storage@6.1.4but passes withpublicPath: 'auto'and some other changes (either here or in-www).Sorry, @yokobond ! I hope we can figure this out for a future version.