Fix collapse when creating a custom procedure with % in label#3244
Open
alexcui03 wants to merge 1 commit intoscratchfoundation:developfrom
Open
Fix collapse when creating a custom procedure with % in label#3244alexcui03 wants to merge 1 commit intoscratchfoundation:developfrom
alexcui03 wants to merge 1 commit intoscratchfoundation:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Add a escape for
%when adding a label in procedure declaration block.Reason for Changes
This pull request fixed the collapse when creating a custom procedure with
%in a label. In the functionBlockly.ScratchBlocks.ProcedureUtils.updateDeclarationProcCode_, I add escape for%when adding a label to ensure all%s in label should be\%in procCode, because Scratch treats\%in procCode as a escape of%. (see blocks_vertical/procedures.js#L207)Test Coverage
None.