-
Notifications
You must be signed in to change notification settings - Fork 25
Use contextual exn-based errors in DEEPWELL #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
emmiegit
wants to merge
90
commits into
develop
Choose a base branch
from
error
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should produce very nice error messages that show the relevant code path and assist with debugging.
Contains the basic string line for the kind of error previously simply rendered via Display using thiserror.
Now the new one is default, and all the prior uses are OldError, OldResult, etc.
This is being handled directly by error types like Login instead.
As Exn intended, use different error types for different errors to enforce adding context at boundaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the [
exn] crate toas described in
Example error response:
With the error JSON itself being:
{ "code": 4101, "message": "User slug cannot be empty", "data": { "call_trace": "[1001] method 'user_create' failed, at src/api.rs:378:5\n|\n|-> [1008] failed to create user, at src/endpoints/user.rs:37:10\n|\n|-> [4101] cannot create user with empty slug, at src/services/user/service.rs:931:9", "code_trace": [ 1001, 1008, 4101 ], "extra": null } }