fix portfwd issue when dealing with server response failures#7252
Merged
notimaginative merged 1 commit intoscp-fs2open:masterfrom Feb 28, 2026
Merged
Conversation
An upstream bug in libpcpnatpmp caused it to not pass along ping failure messages in the internal state which then triggered multiple issues with both the library itself and FSO. This fixes the bug in the pcp library and takes care of the portfwd log spam issues in FSO as well.
notimaginative
added
fix
wookieejedi
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An upstream bug in libpcpnatpmp caused it to not pass along ping failure messages in the internal state which then triggered multiple issues with both the library itself and FSO. This fixes the bug in the pcp library and takes care of the portfwd log spam issues in FSO as well.