fix: respect PHP_MEMORY_LIMIT for composer

[PixelJonas]

After setting PHP_MEMORY_LIMIT to -1 composer still exited with an OOM error.
Setting the parameter directly through php fixed the issue

[centos-ci]

Can one of the admins verify this patch?

[centos-ci]

Can one of the admins verify this patch?

[centos-ci]

Can one of the admins verify this patch?

[rhscl-bot]

Can one of the admins verify this patch?

[rhscl-bot]

Can one of the admins verify this patch?

[rhscl-bot]

Can one of the admins verify this patch?

[PixelJonas]

any chance this is getting merged? I'm currently monkey-patching the assemble file :(

[rhscl-bot]

Can one of the admins verify this patch?

[PixelJonas]

This is still an open issue for me? can anyone verify this patch?

[PixelJonas]

any chance this will ever get merged?

[phracek]

[test-all]

[phracek]

@PixelJonas Thanks for the PR!. Any documentation about this change? I am not familiar with php ;)

[phracek]

@PixelJonas Can you please include it into the other versions, 7.4?

[PixelJonas]

I added the snippet to 7.3 and 7.4 as well. TBH my PHP knowledge is not that extensive and this PR was from a small engagement where needed to install a contao-cms based system in OpenShift V3. Digging through the code PHP_MEMORY_LIMIT seems to be the community default to set memory limit for PHP.

This is not respected when directly using the composer.phar as I was getting OOM errors when installing contao. I monkey-patched this and it worked.

As I don't find any documentation about PHP_MEMORY_LIMIT inside this repo, where would be a good place to add this to an existing doc?

Lastly, looking at the test-bed I do see errors all over the place. Is the test-bed in a "known good state", so these errors are coming from my change?

[phracek]

[test-all]

[phracek]

@remicollet Does it make sense for you this PR?

@PixelJonas Can you please add this change also for (https://github.com/sclorg/s2i-php-container/blob/master/8.0/s2i/bin/assemble)

[test-all]

[phracek]

Please add this also into 8.0 version.

[PixelJonas]

I added the patch to 8.0

[remicollet]

I can understand the need to set memory limit for cli command (e.g. composer)
but I don't think it make sense to use the same value for web process (usually quite low) and for cli process (usually quite high)

It could be better to use 2 configuration options

• PHP_MEMORY_LIMIT for web process, set using php_value in httpd.conf (mod_php) or www.conf (php-fpm)
• PHP_MEMORY_LIMIT_CLI set for other process in php.ini

BTW, for now PHP_MEMORY_LIMIT is set is php.ini, so should be used by composer, which mean php.ini is NOT properly populated (after composer step ?)

[phracek]

@PixelJonas Can you please fix it as @remicollet propose two solutions?

[PixelJonas]

That heavily depends on the timeframe you are expecting this to be done. Right now I don't see the bandwidth to do that, as this looks like something which needs to be tested and I don't have a scenario this is actually being used in (this PR is from 2019).

[github-actions]

Pull Request validation

Failed

🔴 Approval - missing or changes were requested

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member