tests: improve golangci-lint local install and bump version#4
Conversation
also minor polishing in Makefile
Summary of ChangesHello @murfffi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the developer experience by streamlining the local setup for code quality tools and enhancing the project's Makefile structure. It ensures that golangci-lint is consistently installed and used at a specific version, while also making the Makefile more organized and user-friendly for common development tasks. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves the local development setup by installing golangci-lint as a binary instead of using go run, which should improve performance. The Makefile is also nicely refactored. However, there is a critical issue in the new golangci-lint installation command that will cause it to fail due to an incorrect version number. I've provided a fix for this and an additional suggestion to automate the tool's update process, addressing a point you noted in a comment.
also minor polishing in Makefile