Skip to content

tests: add modernize check #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murfffi merged 1 commit into from
Sep 16, 2025
Merged

tests: add modernize check #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ jobs:
make test
- name: Checks
run: |
sudo apt-get install moreutils -y
make check_vuln check_tidy
make checks

# platforms:
# runs-on: ${{ matrix.os }}
Expand Down
9 changes: 9 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ short-test:
lint:
go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.5 run -v

.PHONY: checks
checks: check_tidy check_vuln check_modern

.PHONY: check_vuln
check_vuln:
go run golang.org/x/vuln/cmd/govulncheck@v1.1.4 ./...
Expand All @@ -33,3 +36,9 @@ check_tidy:
go mod tidy
# Verify that `go mod tidy` didn't introduce any changes. Run go mod tidy before pushing.
git diff --exit-code --stat go.mod go.sum

.PHONY: check_modern
check_modern:
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@v0.20.0 ./...
# non-zero exit status on issues found
# nb: modernize is not part of golangci-lint yet - https://github.com/golangci/golangci-lint/issues/686
Loading