Increased calibration resolution #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expanded type p_load (calib value) to long, including functions locals
Author
|
@jlelli Any interest in this? |
Author
|
@jlelli @vingu-linaro ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: I had calibration times in the range from 1-20ns with task step times of 1ms. As a result, the runtimes were very off..
Changed the variables to long and calibration to store the 1000 loop average instead of the single loop average. The division truncates and causes up to 1 digit errors. For a 20ns calibration result, this makes a 5% error; with smaller values even more.
Changed configuration parse to detect also double, and store both int and double JSON values as a calibration value in picoseconds, again as long (resolution increased by 1000)