Skip to content

Conversation

@cboulay
Copy link
Collaborator

@cboulay cboulay commented Jan 17, 2026

Close #247

This is a redo of #253 , originally by @myd7349. The only difference is that it is rebased on dev after I updated some GHA secrets. Either that, or the fact that this is coming from my account, should bypass the errors related to secret access.

Original text:

I have fixed the compilation error on Ubuntu.

Specifically, this error occurs when -DLSL_BUNDLED_PUGIXML=OFF is specified:

- {name: "ubuntu-24.04-x64", os: "ubuntu-24.04", arch: "x86_64", cmake_extra: "-DLSL_BUNDLED_PUGIXML=OFF" }

pugixml 1.15 added std::string overloads (in fact, std::string_view) for some APIs, but older versions of pugixml do not support them. When liblsl is built against a non-bundled pugixml prior to 1.15, these issues arise. Therefore, to use the new overloads while remaining compatible with older pugixml versions, it is necessary to check whether the PUGIXML_HAS_STRING_VIEW macro is defined.

https://github.com/zeux/pugixml/blob/v1.15/src/pugixml.hpp#L445-L447

@cboulay
Copy link
Collaborator Author

cboulay commented Jan 17, 2026

I just wanted to verify that the apple tests pass, which they do. We can return to using #253

@cboulay cboulay closed this Jan 17, 2026
@cboulay cboulay reopened this Jan 17, 2026
@cboulay cboulay marked this pull request as draft January 17, 2026 18:42
@cboulay cboulay closed this Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] Leverage std::string in pugixml 1.15

3 participants