Leverage std::string overloads in pugixml 1.15 #254
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #247
This is a redo of #253 , originally by @myd7349. The only difference is that it is rebased on
devafter I updated some GHA secrets. Either that, or the fact that this is coming from my account, should bypass the errors related to secret access.Original text:
I have fixed the compilation error on Ubuntu.
Specifically, this error occurs when
-DLSL_BUNDLED_PUGIXML=OFFis specified:liblsl/.github/workflows/cppcmake.yml
Line 43 in 63741a9
pugixml 1.15 added std::string overloads (in fact, std::string_view) for some APIs, but older versions of pugixml do not support them. When liblsl is built against a non-bundled pugixml prior to 1.15, these issues arise. Therefore, to use the new overloads while remaining compatible with older pugixml versions, it is necessary to check whether the
PUGIXML_HAS_STRING_VIEWmacro is defined.https://github.com/zeux/pugixml/blob/v1.15/src/pugixml.hpp#L445-L447