Skip to content

Conversation

@ahopkins
Copy link
Member

Extracts logging config to pass to the background logger

Comment on lines +3 to +9
from typing import Any, Dict, Optional, TypedDict


class LoggerConfig(TypedDict):
level: str
propagate: bool
handlers: list[str]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from typing import Any, Dict, Optional, TypedDict
class LoggerConfig(TypedDict):
level: str
propagate: bool
handlers: list[str]
from typing import Any, Dict, List, Optional, TypedDict
class LoggerConfig(TypedDict):
level: str
propagate: bool
handlers: List[str]

Simple fix for the CI failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants