Skip to content

Validate missing elements against parsed metadata #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkiahstroud wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate missing elements against parsed metadata #981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions app/models/bulkrax/csv_entry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def self.data_for_entry(data, _source_id, parser)
end

def build_metadata
validate_record
raise StandardError, 'Record not found' if record.nil?

self.parsed_metadata = {}
add_identifier
Expand All @@ -82,15 +82,12 @@ def build_metadata
sanitize_controlled_uri_values!
add_local

self.parsed_metadata
end

def validate_record
raise StandardError, 'Record not found' if record.nil?
unless importerexporter.parser.required_elements?(record)
unless importerexporter.parser.required_elements?(self.parsed_metadata)
raise StandardError, "Missing required elements, missing element(s) are: "\
"#{importerexporter.parser.missing_elements(record).join(', ')}"
"#{importerexporter.parser.missing_elements(self.parsed_metadata).join(', ')}"
end

self.parsed_metadata
end

def add_identifier
Expand Down