Replace crib position input with interactive slider modal#124
Merged
Conversation
Replace the plain number TextInput for crib position with a CribPositionModal that lets users visually slide the crib along the ciphertext. The modal shows ciphertext and crib letters in aligned rows, highlights conflicts in red (where a letter would encrypt to itself), and disables confirm when invalid. Also centralizes page padding in the Page template component so all screens get consistent padding from a single source. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CribPositionModalthat lets users visually slide the crib along the ciphertext using arrow buttonsPagetemplate component — removes per-pagepaddingVerticaloverrides so all screens get consistentpadding: 16from a single sourcefindConflictIndiceshelper tocrib-analysis.tsxfor detecting letter-to-self conflicts at a given positionTest plan
npm run lintpasses (0 errors)npm testpasses (149 tests)🤖 Generated with Claude Code