Skip to content

Conversation

@andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented Jan 19, 2026

closes #1376

i implemented transferFromPayable instead because the compiler doesn’t allow adding override and the payable specifier to a non-payable function:

     Error: Compiler run failed:                                                                                       
     Error (6959): Overriding function changes state mutability from "nonpayable" to "payable".                        
        --> src/SablierFlow.sol:527:5:                                                                                 
         |                                                                                                             
     527 |     function transferFrom(address from, address to, uint256 tokenId) public payable override {              
         |     ^ (Relevant source part starts here and spans across multiple lines).                                   
     Note: Overridden function is here: 

note: i added the function to lockup as well because i think it’s good for consistency. lmk if you agree or if you consider the increased size a problem (it’s still below the margin)

├── when ETH value is zero
│ ├── it should transfer the NFT
│ └── it should emit {MetadataUpdate} and {Transfer} events
└── when ETH value is greater than zero
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmk if you think we only need one branch, or if keeping both is ok

also, do you think we should use transferFromPayable in the batch tests? IMO these are sufficient

@andreivladbrg
Copy link
Member Author

@smol-ninja the fork tests seem to be failing. i tested locally, and this is not related to this PR, as it failed in staging as well. let’s fix it in another PR

@smol-ninja
Copy link
Member

@andreivladbrg the fork tests are fixed in #1366. See 2539c05

@smol-ninja smol-ninja force-pushed the feat/payable-transfer-from branch from 4287bd5 to bc0f42c Compare January 20, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants