Add unit tests for ViomiVacuum (viomi.vacuum.v8)#2061
Open
Acrobot wants to merge 2 commits intorytilahti:masterfrom
Open
Add unit tests for ViomiVacuum (viomi.vacuum.v8)#2061Acrobot wants to merge 2 commits intorytilahti:masterfrom
Acrobot wants to merge 2 commits intorytilahti:masterfrom
Conversation
The ViomiVacuum integration had zero test coverage. This adds 63 tests covering status parsing, vacuum state mapping, error codes, all device commands, DND, consumables, map/room operations, and position tracking.
Author
|
These changes were generated using Claude Code under my supervision. I reviewed and approved all code before submitting. I'm not very familiar with this codebase, so apologies in advance for any mistakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViomiVacuum had no test coverage. This adds tests for the v8 model, covering:
is_charge/is_workbooleans)VacuumStatemapping and error code handling63 tests total, all passing. No new failures in the full suite.