Skip to content

upki: add binary index to improve performance#89

Open
djc wants to merge 1 commit intomainfrom
index
Open

upki: add binary index to improve performance#89
djc wants to merge 1 commit intomainfrom
index

Conversation

@djc
Copy link
Copy Markdown
Member

@djc djc commented Mar 20, 2026

No description provided.

@djc djc requested a review from ctz March 20, 2026 10:56
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 20, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
🆕 1 new benchmark

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 e2e-revocation-check N/A 12.6 ms N/A

Comparing index (eedab61) with main (b10582a)

Open in CodSpeed

@djc djc force-pushed the index branch 4 times, most recently from fb63488 to 0ccf415 Compare March 20, 2026 11:34
@djc
Copy link
Copy Markdown
Member Author

djc commented Mar 20, 2026

So apparently this doesn't actually improve performance in revocation-check? Codspeed has it unchanged (but mentions it is ignoring time spent in syscalls, which might be problematic for this). Criterion locally assesses it as a ~7% regression, which I'm assuming includes time spent in syscalls?

@djc djc force-pushed the index branch 4 times, most recently from 61cb762 to 8502177 Compare March 20, 2026 12:06
Copy link
Copy Markdown
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good in substance and structure, just would like to understand the performance element more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants