fix!: Don't panic when reading empty files #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
simonsan
reviewed
Dec 10, 2024
aawsome
changed the title
simonsan
approved these changes
Dec 10, 2024
Closed
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
## 🤖 New release * `rustic_backend`: 0.5.2 -> 0.5.3 (✓ API compatible changes) * `rustic_core`: 0.7.3 -> 0.8.0 (✓ API compatible changes) * `rustic_testing`: 0.3.2 -> 0.3.3 (✓ API compatible changes) * `rustic_config`: 0.2.2 -> 0.2.3 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `rustic_backend` <blockquote> ## [0.5.3](rustic_backend-v0.5.2...rustic_backend-v0.5.3) - 2025-09-12 ### Fixed - fix clippy lints ([#407](#407)) - *(deps)* lock file maintenance rust dependencies (#389) ### Other - update dependencies ([#428](#428)) - update to 2024 edition and fix clippy lints (#399) - update dependencies and fix clippy lints / remove opendal::ftp support (#405) - Update opendal to 0.51.0 (#391) </blockquote> ## `rustic_core` <blockquote> ## [0.8.0](rustic_core-v0.7.3...rustic_core-v0.8.0) - 2025-09-12 ### Added - Add fixed size chunking and allow fine-tune of rabin chunking (#422) - Add env argument to the run function of command input (#420) - Show processed file when chunker gives an error (#421) - snapshots can be identified with latest~N (N >= 0) (#416) - expose Tree::serialize method - *(repository)* add progress_bars method - *(repository)* Add find_ids and stream_files_list (#411) - *(commands)* Add delete_unchanged option to forget (#386) - *(commands)* [**breaking**] rename backup skip_identical_parent to skip_if_unchanged (#387) - *(warmup)* [**breaking**] Add warmup wait command (#379) ### Fixed - Make example for time format even more explicit (#425) - Add example for time format (#424) - fix clippy lints ([#423](#423)) - [**breaking**] Allow to unset append-only mode (#414) - improve handling of u32 conversions (#412) - *(repository)* use KeyId in delete_key() (#410) - Fix repair index (#406) - Allow to request identical snapshot multiple times (#408) - fix clippy lints ([#407](#407)) - fix clippy lints - [**breaking**] Don't panic when reading empty files (#381) ### Other - update dependencies ([#428](#428)) - Add SnapshotFile::from_strs() to search for multiple snapshots ([#419](#419)) - *(repository)* [**breaking**] Add more control over used keys (#383) - update to 2024 edition and fix clippy lints (#399) - update dependencies and fix clippy lints / remove opendal::ftp support (#405) </blockquote> ## `rustic_testing` <blockquote> ## [0.3.3](rustic_testing-v0.3.2...rustic_testing-v0.3.3) - 2025-09-12 ### Other - update to 2024 edition and fix clippy lints (#399) - update dependencies and fix clippy lints / remove opendal::ftp support (#405) </blockquote> ## `rustic_config` <blockquote> ## [0.2.3](rustic_config-v0.2.2...rustic_config-v0.2.3) - 2025-09-12 ### Other - update to 2024 edition and fix clippy lints (#399) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when using partition_point which in that case does not gave guarentees about its behavior. Hence the whole logic was refactored and unit/integration tests were added.
closes rustic-rs/rustic#1380