Remove WindowBuilder in favour of WindowAttributes#3400
Closed
Remove WindowBuilder in favour of WindowAttributes#3400
WindowBuilder in favour of WindowAttributes#3400Conversation
Move `PlatformSpecificWindowBuilderAttributes` into `WindowAttributes`.
Member
|
I think I have it ported on winit-next the way you suggested, however there's an issue with extensibility of it in the future. Like with dynamic backend we can't really account for everything ahead of time, so I was thinking that maybe we should create a But in general having the same type is fine by me. it's called a builder because of the pattern with the |
5 tasks
Member
|
Closing in favor #3447. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on #3318.
Rough draft, the plan is to move towards:
I think in this case it makes sense to remove the builder, because it really is just attributes; but in a case like
EventLoopBuilder, I think it still makes sense to keep that as a builder.CHANGELOG.mdif knowledge of this change could be valuable to users