Generalize signal.rs to be used on non-Linux systems#263
Open
slp wants to merge 4 commits intorust-vmm:mainfrom
Open
Generalize signal.rs to be used on non-Linux systems#263slp wants to merge 4 commits intorust-vmm:mainfrom
slp wants to merge 4 commits intorust-vmm:mainfrom
Conversation
The syscall sigtimedwait is not available on some non-Linux systems. Let's use sigwait on them as a first step to be able to generalize signal.rs Signed-off-by: Sergio Lopez <slp@redhat.com>
The functions __libc_current_sigrtmin and __libc_current_sigrtmax are generally not available on non-Linux systems. Exclude them, and all the methods using them, to be able to generalize signal.rs. Signed-off-by: Sergio Lopez <slp@redhat.com>
In the previous commits we've prepared signal.rs to be usable on non-Linux systems. Let's commit to it by moving the signal module from linux to unix. Signed-off-by: Sergio Lopez <slp@redhat.com>
slp
requested review from
ShadowCurse,
andreeaflorescu,
jiangliu,
liujing2,
roypat and
sameo
as code owners
Signed-off-by: Sergio Lopez <slp@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Most of the functionality in
signalcan be used on non-Linux systems. This PR gates the Linux-specific functionality behind build-time conditionals and moves thesignalmodule fromlinuxtounix.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.