fix: handle empty span in span_before to prevent panic#6833
Closed
themavik wants to merge 1 commit intorust-lang:mainfrom
Closed
fix: handle empty span in span_before to prevent panic#6833themavik wants to merge 1 commit intorust-lang:mainfrom
themavik wants to merge 1 commit intorust-lang:mainfrom
Conversation
Fixes rust-lang#5716 Made-with: Cursor
rustbot
added
the
S-waiting-on-review
Contributor
|
I can no longer reproduce the bug. See my comment: #5716 (comment) |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
span_beforegracefully instead of panickingt.0.10i32Root Cause
span_beforepanics when the source snippet for a span is empty, which can happen with certain tuple index expressions.Testing
Fixes #5716
Made with Cursor