Skip to content

Conversation

@Jamesbarford
Copy link
Contributor

Adds two tabs to choose between x86_64-unknown-linux-gnu and aarch64-unknown-linux-gnu. I originally thought to use a <select> however you can't embed <a> tags in an <option>

Screenshot from 2026-01-12 15-38-32

@Jamesbarford Jamesbarford force-pushed the feat/dashboard-switch-target branch from 96eb061 to 0584f5f Compare January 13, 2026 08:42
@Jamesbarford Jamesbarford requested a review from Kobzol January 13, 2026 11:11
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally thought to use a however you can't embed tags in an What is the reason you needed <a> tags? To make it easier to change the URL and reload the page, without having to do it in JavaScript in the select change event handler? Looks good overall, I don't think that we need to do JS magic here and just the <a> links are enough for now. That being said, I'm not sure if there's much point in merging this until we actually have some ARM data? It would likely be a bit confusing if there is a link that points to empty data or an error. We can merge it once we have a machine and backfill the ARM historical data (hopefully that will work :) ).

populate_data(response);
} else {
const responseText = await apiResponse.text();
Highcharts.chart({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you render a chart when there's an error? We can just display the error in some text label, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed the simplest thing to do as we don't really have access to the DOM in this file however this file is also the one that makes the API call.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Well, the right thing to do to make this page modifiable in the future is to move all the code from dashboard.ts to src/pages/dashboard.page.vue, so that we get access to the DOM :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ba2eaa7 👍

@Jamesbarford
Copy link
Contributor Author

Jamesbarford commented Jan 14, 2026

I originally thought to use a however you can't embed tags in an

What is the reason you needed tags? To make it easier to change the URL and reload the page, without having to do it in JavaScript in the select change event handler?
Looks good overall, I don't think that we need to do JS magic here and just the links are enough for now. That being said, I'm not sure if there's much point in merging this until we actually have some ARM data? It would likely be a bit confusing if there is a link that points to empty data or an error. We can merge it once we have a machine and backfill the ARM historical data (hopefully that will work :) ).

Yes an <a> made it easier to change the page and not have to worry about any state. I don't know if this is the idiomatic VUE.js way of doing it however.

Good point, there's a reasonable amount of plumbing here that would be nice to get in. We could add to the table wrapper css class;

.target-wrapper {
    // current styles
    display: none;
    height: 0px;
}

And make the url links empty strings?

Edit;
Another compelling reason would be to make things easier to work with locally

@Kobzol
Copy link
Member

Kobzol commented Jan 15, 2026

Looking at the changes of this PR and your comments, I'd suggest first moving the dashboard page to a proper Vue component, so that we can actually do things like show errors 😆 It will be needed to make bigger changes to the page in the future anyway.

@Jamesbarford Jamesbarford force-pushed the feat/dashboard-switch-target branch from ba2eaa7 to cf06098 Compare January 15, 2026 15:38
@Jamesbarford Jamesbarford force-pushed the feat/dashboard-switch-target branch from cf06098 to 0ca0905 Compare January 16, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants