remove ibraheemdev from review rotation#155303
remove ibraheemdev from review rotation#155303WaffleLapkin wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
|
rustbot
added
A-meta
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| libs = [ | ||
| "@Mark-Simulacrum", | ||
| "@workingjubilee", | ||
| "@jhpratt", | ||
| "@tgross35", | ||
| "@thomcc", | ||
| "@ibraheemdev", | ||
| "@joboet", | ||
| ] |
There was a problem hiding this comment.
I'm surprised to see that T-libs doesn't use triagebot's review queue tracking. If they did, it would be as simple as PM'ing triagebot as ibraheemdev work set-team-rotation-mode libs off.
There was a problem hiding this comment.
Doesn't this work as an override for what's in the file? I feel like I have used it in the past.
There was a problem hiding this comment.
Yeah the issue is that libs in triagebot.toml has very small overlap with t-libs. Otherwise we would remove it from the triagebot config file already.
There was a problem hiding this comment.
Is there any way to alias r? libs to libs+libs-api+libs-contributors? I think that would cover the available pool, then we just adjust rotations for anyone who isn't on it now.
There was a problem hiding this comment.
Perhaps we should consider restructuring libs in the same way as compiler did. That is, have one "libs" team containing everybody and then more specific groups of people with, e.g.libs or libs-api fcp rights.
There was a problem hiding this comment.
I think @Amanieu may have mentioned that as a possibility at some point.
|
Sorry, I meant to do this myself a while ago! I'll add myself back once I have more time. |
There was a problem hiding this comment.
@bors r+ rollup
It would be nice if this wasn't needed but for the time being, seems like this is thing to do.
Thanks @ibraheemdev!
rust-bors
bot
added
S-waiting-on-bors
remove ibraheemdev from review rotation @ibraheemdev haven't reviewed any r-l/r PRs since October last year and has a backlog of [8 PRs at the moment of writing this](https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+assignee%3Aibraheemdev+label%3AS-waiting-on-review). @ibraheemdev thank you for the reviews that you have done in the past! feel free to re-add yourself once you have time for this again :)
Rollup of 13 pull requests Successful merges: - #154882 (Gate tuple const params behind `min_adt_const_params` feature) - #155259 (explicit-tail-calls: disable two tests on LoongArch) - #155293 (fix arch names in cfg pretty printer) - #155314 (`BorrowedBuf`: Update outdated safety comments in `set_init` users.) - #153469 (docs: clarify path search behavior in std::process::Command::new) - #154765 (Clarify ascii whitespace exclusion of vertical tab in the doc) - #155172 (Some small nits for supertrait_item_shadowing, and additional testing) - #155279 (Test/lexer unicode pattern white space) - #155280 (Tests for precise-capture through RPIT and TAIT) - #155301 (Delete unused `rustc_trait_selection` errors.) - #155303 (remove ibraheemdev from review rotation) - #155304 (remove PointeeParser) - #155319 (Remove dead diagnostic structs.)
8 participants
@ibraheemdev haven't reviewed any r-l/r PRs since October last year and has a backlog of 8 PRs at the moment of writing this.
@ibraheemdev thank you for the reviews that you have done in the past! feel free to re-add yourself once you have time for this again :)