attribute cleanup: rustc_confusables

[mejrs]

r? @jdonszelmann

[rustbot]

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

[JonathanBrouwer]

The old code ran this query only one time, the new code runs it multiple times, lets see if that matters

View changes since the review

[JonathanBrouwer]

@bors try @rust-timer queue

[JonathanBrouwer]

r=me if perf does not regress

View changes since this review

[JonathanBrouwer]

@bors delegate

[rust-bors]

✌️ @mejrs, you can now approve this pull request!

If @JonathanBrouwer told you to "r=me" after making some further change, then please make that change and post @bors r=JonathanBrouwer.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 66dc2b0 (66dc2b0a0b032e0a19ddf7ad6bc699bbfb3fa63c, parent: 12f35ad39ed3e39df4d953c46d4f6cc6c82adc96)

[rust-timer]

Finished benchmarking commit (66dc2b0): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 9.6%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	11.4%	[2.5%, 19.8%]	7
Regressions ❌ (secondary)	4.2%	[2.7%, 7.0%]	3
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-3.4%	[-4.4%, -2.3%]	2
All ❌✅ (primary)	9.6%	[-2.9%, 19.8%]	8

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.936s -> 490.673s (0.15%)
Artifact size: 394.18 MiB -> 394.15 MiB (-0.01%)

[JonathanBrouwer]

@bors r+ rollup
Perf is noise

[rust-bors]

📌 Commit f17ca97 has been approved by JonathanBrouwer

It is now in the queue for this repository.