Rollup of 4 pull requests by JonathanBrouwer · Pull Request #153355 · rust-lang/rust

JonathanBrouwer · 2026-03-03T18:11:51Z

Successful merges:

Use shell-words to parse output from llvm-config #152712 (Use shell-words to parse output from llvm-config)
Stabilize control_flow_ok #152911 (Stabilize control_flow_ok)
Fix LegacyKeyValueFormat report from docker build: host-aarch64 #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64)
MGCA: fix type error handling for const array and tuple lowering logic #153345 (MGCA: fix type error handling for const array and tuple lowering logic)

llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the shell-words crate to parse the output.

@tmiasko

Use shell-words to parse output from llvm-config llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the [shell-words](https://crates.io/crates/shell-words) crate by @tmiasko (a new dependency) to parse the output. r? ChrisDenton Fixes rust-lang#152707

@dtolnay

…dtolnay Stabilize `control_flow_ok` Feature: `control_flow_ok` Tracking issue: rust-lang#140266 r? @dtolnay

@marcoieni

…alueFormat-aarch64, r=marcoieni Fix LegacyKeyValueFormat report from docker build: host-aarch64 Part of rust-lang#152305 Following rust-lang#153109 r? @marcoieni

@fmease

…, r=fmease MGCA: fix type error handling for const array and tuple lowering logic It's a simple fix; just needed to handle Ty::Error in `lower_const_arg_array` and `lower_const_arg_tup` Fixes rust-lang#153254 r? @fmease

JonathanBrouwer · 2026-03-03T18:12:03Z

@bors r+ rollup=never p=5

rust-bors · 2026-03-03T18:12:06Z

📌 Commit 0605ef5 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 4 pull requests Successful merges: - #152712 (Use shell-words to parse output from llvm-config) - #152911 (Stabilize `control_flow_ok`) - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64) - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)

rust-log-analyzer · 2026-03-03T19:01:40Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20260213.493
Commit: 5c115507f6dd24b8de37d8bbe0bb4509d0cc0fa3
Build Date: 2026-02-13T00:28:41Z
Worker ID: {0263d749-8857-4935-a550-74fadb2e7e8a}
Azure Region: westcentralus
##[endgroup]
##[group]Operating System
Ubuntu
24.04.3
LTS
---
/dev/sda15      105M  6.2M   99M   6% /boot/efi
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (94915316KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
Command `git clone --depth=1 https://github.com/rust-lang-nursery/rust-toolstate rust-toolstate` failed with exit code 128
Created at: src/bootstrap/src/core/build_steps/toolstate.rs:314:5
Executed at: src/bootstrap/src/core/build_steps/toolstate.rs:319:10

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:10
  local time: Tue Mar  3 19:01:24 UTC 2026
  network time: Tue, 03 Mar 2026 19:01:24 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

rust-bors · 2026-03-03T19:02:38Z

💔 Test for 9c4bb2e failed: CI. Failed job:

auto - x86_64-gnu-tools (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-03-03T19:03:53Z

@bors retry

…uwer Rollup of 4 pull requests Successful merges: - #152712 (Use shell-words to parse output from llvm-config) - #152911 (Stabilize `control_flow_ok`) - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64) - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)

rust-bors · 2026-03-03T19:09:32Z

💔 Test for 9dca545 failed: CI. Failed job:

auto - x86_64-gnu-llvm-20 (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-03-03T19:25:06Z

@bors treeclosed=1000
@bors retry

rust-bors · 2026-03-03T19:25:09Z

Tree closed for PRs with priority less than 1000.

JonathanBrouwer · 2026-03-03T19:25:35Z

@bors p=1000

rust-log-analyzer · 2026-03-03T19:45:04Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

JonathanBrouwer · 2026-03-03T21:18:08Z

@bors treeopen

rust-bors · 2026-03-03T21:18:11Z

Tree is now open for merging.

rust-bors · 2026-03-03T23:16:46Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 50m 31s
Pushing d956393 to main...

rust-timer · 2026-03-03T23:17:55Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#152712	Use shell-words to parse output from llvm-config	`7f20df733064cb506007630b5325863e4e76c1b0` (link)
#152911	Stabilize `control_flow_ok`	`d431560dcb9063f15c998acaaa18e1b3e141e0ff` (link)
#153223	Fix LegacyKeyValueFormat report from docker build: host-aar…	`fd394ae4944a837ce5cf47fee7feaec6d6a5bb83` (link)
#153345	MGCA: fix type error handling for const array and tuple low…	`89b1b9b17adcb7da42d726a75f963e8a5bc32004` (link)

previous master: d2218f5f5c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-03-03T23:19:38Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d2218f5 (parent) -> d956393 (this PR)

Test differences

Show 16 test diffs

Stage 1

[ui] tests/ui/const-generics/mgca/syntactic-type-mismatch.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/const-generics/mgca/syntactic-type-mismatch.rs: [missing] -> pass (J0)

Additionally, 14 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d9563937fa3b030c5845811113505070109414d2 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 2h 42m -> 1h 59m (-26.5%)
pr-check-1: 33m 38s -> 28m 14s (-16.1%)
x86_64-gnu-tools: 1h -> 51m 40s (-15.0%)
i686-gnu-2: 1h 45m -> 1h 30m (-14.3%)
x86_64-rust-for-linux: 52m 8s -> 44m 58s (-13.7%)
dist-aarch64-apple: 2h 17m -> 1h 58m (-13.7%)
i686-gnu-1: 2h 26m -> 2h 7m (-13.1%)
arm-android: 1h 45m -> 1h 32m (-12.9%)
i686-gnu-nopt-1: 2h 24m -> 2h 5m (-12.9%)
x86_64-gnu-aux: 2h 21m -> 2h 2m (-12.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-03-03T23:57:08Z

Finished benchmarking commit (d956393): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.0%, secondary 5.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	5.7%	[5.5%, 5.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

Cycles

Results (secondary 5.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.9%	[5.0%, 6.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.344s -> 480.491s (-0.18%)
Artifact size: 397.04 MiB -> 395.02 MiB (-0.51%)

eggyal and others added 9 commits February 16, 2026 23:57

Use shell-words to parse output from llvm-config

c30e20a

llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the shell-words crate to parse the output.

Stabilize control_flow_ok

e9bf929

Allow unstable const_precise_live_drops in stable

c5da0e3

Fix LegacyKeyValueFormat report from docker build: host-aarch64

797f066

MGCA: fix type error handling for array and tuple lowering logic

ee1d0cf

Rollup merge of rust-lang#152911 - nxsaken:stable_control_flow_ok, r=…

f4810cb

…dtolnay Stabilize `control_flow_ok` Feature: `control_flow_ok` Tracking issue: rust-lang#140266 r? @dtolnay

Rollup merge of rust-lang#153223 - homersimpsons:chore/fix-LegacyKeyV…

340497d

…alueFormat-aarch64, r=marcoieni Fix LegacyKeyValueFormat report from docker build: host-aarch64 Part of rust-lang#152305 Following rust-lang#153109 r? @marcoieni

rust-bors bot added the rollup A PR which is a rollup label Mar 3, 2026

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 3, 2026

rust-bors bot mentioned this pull request Mar 3, 2026

Lint unused features #152164

Merged

This comment has been minimized.

Sign in to view

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 3, 2026

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 3, 2026

rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2026

rust-bors bot mentioned this pull request Mar 3, 2026

Use shell-words to parse output from llvm-config #152712

Merged

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2026

rust-bors bot merged commit d956393 into rust-lang:main Mar 3, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Mar 3, 2026

Uh oh!

Conversation

JonathanBrouwer commented Mar 3, 2026

Uh oh!

JonathanBrouwer commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026

Uh oh!

JonathanBrouwer commented Mar 3, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 3, 2026

Uh oh!

JonathanBrouwer commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026

Uh oh!

JonathanBrouwer commented Mar 3, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Mar 3, 2026

Uh oh!

JonathanBrouwer commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026

Uh oh!

Uh oh!

rust-timer commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Mar 3, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants