Open
Conversation
rustbot
added
A-query-system
nnethercote
requested changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Please expand the PR description to explain clearly why cycle_fatal has no effect. (I know, because I worked it out two days ago, but to anyone else who comes across this PR it won't be clear, and the change to the comment in plumbing.rs is easy to overlook.)
| // `ty::query::values::Value` can be implemented which produces an appropriate | ||
| // placeholder (error) value if the query resulted in a query cycle. | ||
| // Queries without a `Value` implementation will raise a fatal error on query | ||
| // cycles instead. |
| // `ty::query::values::Value` can be implemented which produces an appropriate | ||
| // placeholder (error) value if the query resulted in a query cycle. | ||
| // Queries without a `Value` implementation will raise a fatal error on query | ||
| // cycles instead. |
Contributor
There was a problem hiding this comment.
And this will need updating because values::Value is being renamed from_cycle_error::FromCycleError.
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
nnethercote
added
the
S-blocked
Contributor
|
Blocked on #153169. |
Contributor
|
☔ The latest upstream changes (presumably #153278) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
That PR has merged, and this PR is now unblocked. |
nnethercote
removed
the
S-blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
cycle_fatalquery modifier as it has no effect on its current users.r? @nnethercote