Skip to content

Revert "resolve: Downgrade ambiguous_glob_imports to warn-by-default"#152549

Open
petrochenkov wants to merge 1 commit intorust-lang:mainfrom
petrochenkov:diesel3
Open

Revert "resolve: Downgrade ambiguous_glob_imports to warn-by-default"#152549
petrochenkov wants to merge 1 commit intorust-lang:mainfrom
petrochenkov:diesel3

Conversation

@petrochenkov
Copy link
Contributor

This reverts commit cd05071.

Revert of #151130.
This will need to be merged after ~February 27 2026, when Rust 1.95 branches out from the main branch.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 12, 2026
@petrochenkov petrochenkov marked this pull request as ready for review February 12, 2026 16:31
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 16 candidates

@petrochenkov petrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2026
@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 12, 2026

r? compiler

@petrochenkov
Copy link
Contributor Author

New beta branch was created, this can be merged.
@rustbot ready

There's not much to review here, this revert implements the second step of lang team decision from #149845 (comment).
Anyone can approve this, preferably soon because other work is blocked on this.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 1, 2026
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 1, 2026

📌 Commit 5c037af has been approved by fmease

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 1, 2026
Revert "resolve: Downgrade `ambiguous_glob_imports` to warn-by-default"

This reverts commit cd05071.

Revert of rust-lang#151130.
This will need to be merged after ~February 27 2026, when Rust 1.95 branches out from the main branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants