Skip to content

Conversation

@ViewWay
Copy link

@ViewWay ViewWay commented Jan 17, 2026

Change the UNSTABLE_NAME_COLLISIONS lint from using plain text help to span_suggestion for method calls, providing users with a visual code replacement suggestion.

Previously:
= help: call with fully qualified syntax Trait::method(...) to keep using the current method

Now:
help: call with fully qualified syntax to keep using the current method
|
LL - receiver.method(args)
LL + Trait::method(...)

Fixes #1794 in rustc_hir_typeck/src/method/probe.rs

Change the `UNSTABLE_NAME_COLLISIONS` lint from using plain text
`help` to `span_suggestion` for method calls, providing users with
a visual code replacement suggestion.

Previously:
  = help: call with fully qualified syntax `Trait::method(...)` to keep using the current method

Now:
  help: call with fully qualified syntax to keep using the current method
    |
  LL -     receiver.method(args)
  LL +     Trait::method(...)

Fixes rust-lang#1794 in rustc_hir_typeck/src/method/probe.rs

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

  • The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

    You can start a rebase with the following commands:

    $ # rebase
    $ git pull --rebase https://github.com/rust-lang/rust.git main
    $ git push --force-with-lease
    

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 18, 2026
@ViewWay ViewWay marked this pull request as draft January 18, 2026 01:40
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2026
@ViewWay ViewWay marked this pull request as ready for review January 18, 2026 01:41
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 18, 2026
@chenyukang
Copy link
Member

why there is Fixes #1794 in PR description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-merge-commits PR has merge commits, merge with caution. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants