Skip to content

Fix wrong suggestion for returning async closure#151194

Open
chenyukang wants to merge 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-150701-async-closure
Open

Fix wrong suggestion for returning async closure#151194
chenyukang wants to merge 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-150701-async-closure

Conversation

@chenyukang
Copy link
Copy Markdown
Member

@chenyukang chenyukang commented Jan 16, 2026

Fixes #150701

r? @estebank

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 16, 2026
@SpriteOvO SpriteOvO added A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` A-async-closures `async || {}` labels Jan 16, 2026
Copy link
Copy Markdown
Member

@Kivooeo Kivooeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estebank, is that fine if i reviewed it?

View changes since this review

@wesleywiser
Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 12, 2026

📌 Commit dbb9bbb has been approved by wesleywiser

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 12, 2026
…-closure, r=wesleywiser

Fix wrong suggestion for returning async closure

Fixes rust-lang#150701

r? @estebank
rust-bors bot pushed a commit that referenced this pull request Mar 12, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #153751 (Detect existing turbofish on method calls to suppress useless suggestion)
 - #153780 (Remove `MTLock`)
 - #151194 (Fix wrong suggestion for returning async closure)
 - #151572 (Fix Hexagon ABI calling convention for small aggregates)
 - #153725 (Fix that `./x test --no-doc` actually keeps the same behaviour for backwards compatability)
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@bors r-
#153782 (comment)

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 12, 2026

This pull request was unapproved.

This PR was contained in a rollup (#153782), which was unapproved.

@chenyukang chenyukang force-pushed the yukang-fix-150701-async-closure branch from dbb9bbb to a5bc8d4 Compare March 26, 2026 09:42
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 26, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-async-closures `async || {}` A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional suggestion for returning async closure Future is wrong

7 participants