Skip to content

mgca: Finish implementation of #[type_const] #148716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

mgca: Finish implementation of #[type_const] #148716

wants to merge 19 commits into from
+1,688 −900

Conversation

@camelid
Copy link
Member

@camelid camelid commented Nov 8, 2025 •
edited by rustbot
Loading

Blocked on #139558.

tracking issue: #132980
fixes #140729
fixes #140860

  • Fix #[type_const] attribute placement validation
  • Perform WF-checking on type_const RHS's
  • Check type_const type is ConstParamTy_ and that RHS matches it
  • Check that impls of #[type_const] consts also have the attr

r? @BoxyUwU

BoxyUwU and others added 17 commits November 1, 2025 14:51
@BoxyUwU @camelid
setup canonical normalization for const norm
901664a
@BoxyUwU @camelid
add ConstArgKind::Error
838684b
@camelid
mgca: Add ConstArg representation for const items
0515aa5
@camelid
add const_of_item query and use it in normalization
9864a2f
@BoxyUwU @camelid
Fix const qualifs under mgca
a7626dc
@BoxyUwU @camelid
fix associated_const_equality tests
0a35517
@BoxyUwU @camelid
use right span for inferrable ret ty
d663152
@camelid
Fix rustdoc
f532622
@camelid
Fix clippy
91054e8 
When mgca is enabled, const rhs's that are paths may have false
negatives with the lints in non_copy_const.rs. But these should probably
be using the trait solver anyway, and it only happens under mgca.
@camelid
Update crashes tests based on fixed or changed ICEs
dbb33c7
@camelid
Use "rhs" terminology instead of "body"
66267da
@camelid
Fix rustfmt
339dea8
@camelid
Fix rustdoc tests
5171e42
@camelid
Fix rustdoc UI tests
ad69a7a 
Also removed a test that was literally a duplicate of the one I kept.
@camelid
Add tests for mismatched type_const
45391bd
@camelid
Fix #[type_const] attribute placement validation
c64453e
@camelid
Perform WF-checking on type_const RHS's
f2293ec
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 8, 2025
@camelid camelid added the A-const-generics Area: const generics (parameters and arguments) label Nov 8, 2025
@BoxyUwU BoxyUwU removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Nov 8, 2025
@BoxyUwU BoxyUwU removed T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. T-clippy Relevant to the Clippy team. labels Nov 8, 2025
@camelid camelid added F-min_generic_const_args `#![feature(min_generic_const_args)]` and removed WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camelid camelid mentioned this pull request Nov 8, 2025
Open
18 tasks
@rustbot rustbot added T-clippy Relevant to the Clippy team. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwU BoxyUwU

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-const-generics Area: const generics (parameters and arguments) F-min_generic_const_args `#![feature(min_generic_const_args)]` S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE: normalizing free const aliases in the type system is unsupported ICE:normalizing free const aliases in the type system is unsupported

4 participants

@camelid @rustbot @rust-log-analyzer @BoxyUwU