Skip to content

Conversation

@CAD97
Copy link
Contributor

@CAD97 CAD97 commented Nov 8, 2025

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 8, 2025

Congratulations! I think you should also remove the entry with your deadname, if I understand the mailmap format correctly
@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 8, 2025
@Noratrieb
Copy link
Member

awesome 🏳️‍⚧️ ❤️! but also, uhhhh, i think you're gonna need to rename that branch or bad things will happen. only-emoji branchnames have fucked up github in the past and created prs that were cursed and couldn't be merged. emojis are fine, just only emojis is not

@Noratrieb
Copy link
Member

also remember to change your rust-lang/team entry: https://github.com/rust-lang/team/blob/f2d52d21a4d1f2d7321634454ce65c8d203e30f1/people/CAD97.toml

@CAD97
Copy link
Contributor Author

CAD97 commented Nov 9, 2025

entry with your deadname

Just goes to show how much that isn't my name anymore that I didn't even notice it while finding the alphabetical position for "Crystal" just eight lines lower. Thanks for catching that.

gonna need to rename that branch

New PR it is then, GitHub doesn't allow changing the branch source of a PR as far as I'm aware. And it's hard to check it out locally, even, entering origin/🏳️‍⚧️ is becoming origin/️‍⚧️, I had to use the unicode codepoint escapes. #148722

rust-lang/team

Always something to miss. PR sent. rust-lang/team#2065

@CAD97 CAD97 closed this Nov 9, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 9, 2025
@CAD97 CAD97 deleted the 🏳️‍⚧️ branch November 9, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants