Add f16 and f128 test cases to manual_float_methods#16503
Open
slightsharp wants to merge 1 commit intorust-lang:masterfrom
Open
Add f16 and f128 test cases to manual_float_methods#16503slightsharp wants to merge 1 commit intorust-lang:masterfrom
slightsharp wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
Signed-off-by: slightsharp <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test cases for f16 and f128 types to the
manual_float_methodstest suite. While the lint doesn't currently detect these patterns (which is expected since f16/f128 support may need to be implemented), these test cases serve as:The test cases include both
manual_is_infiniteandmanual_is_finitepatterns for both f16 and f128 types, with the necessary feature flags enabled.changelog: none