Skip to content

Add f16 and f128 test cases to manual_float_methods#16503

Open
slightsharp wants to merge 1 commit intorust-lang:masterfrom
slightsharp:master
Open

Add f16 and f128 test cases to manual_float_methods#16503
slightsharp wants to merge 1 commit intorust-lang:masterfrom
slightsharp:master

Conversation

@slightsharp
Copy link

This PR adds test cases for f16 and f128 types to the manual_float_methods test suite. While the lint doesn't currently detect these patterns (which is expected since f16/f128 support may need to be implemented), these test cases serve as:

  1. Documentation of the expected behavior
  2. Preparation for future f16/f128 support
  3. Regression prevention

The test cases include both manual_is_infinite and manual_is_finite patterns for both f16 and f128 types, with the necessary feature flags enabled.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 3, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2026

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants