Update book for backport, release and sync#12762
Update book for backport, release and sync#12762flip1995 wants to merge 1 commit intorust-lang:masterfrom
Conversation
flip1995
added
the
S-blocked
rustbot
added
the
S-waiting-on-review
|
I've been busy last week and this one is also pretty full. If it's alright with you, I'd push this review into some time next week, probably after the 23rd. |
|
No worries. I'm on a business trip for the next 2 weeks and until then I'll probably won't be able to actually do the switch to Josh. |
flip1995
force-pushed
the
josh-docs-update
branch
from
74aaeb7 to
0dcb0ca
Compare
|
I'll review this some time this week. I also found a related Hackmd, in case you didn't knew about it: https://hackmd.io/7pOuxnkdQDaL1Y1FQr65xg |
|
Yup, this was my guide to setup Josh. Parts of this (and the JOSH) PR can be merged without moving to Josh. Should I split up the PR or are you fine reviewing it like this? |
I'm fine with either. It probably depends on how long you're guesstimating that it'll take to move to JOSH. If it will take more time then it might be better to split the changes. But if it'll be reasonably soon we can keep them all in one PR :D |
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
Well written, I have some NITs, but all of them are superficial. Thank you, for putting this together :D
xFrednet
removed
the
S-waiting-on-review
rustbot
added
S-waiting-on-author
flip1995
force-pushed
the
josh-docs-update
branch
from
0dcb0ca to
cb4d505
Compare
|
Addressed all comments and rebased 👍 Thanks for the reminder. I'll ask the Josh team about the last blocker I see for the move. |
|
Perfect, this version looks good to me. Let's hope the issue is resolved soon :D |
|
We should probably mention the old way, I used it a lot to benchmark changes in Clippy. I can imagine there are other reasons one may want to import a change from Clippy to Rust upstream |
What's the old way? Do you mean the old way to sync? That will no longer work after moving to josh. The only reason I see for importing Clippy changes to Rust upstream is for backporting and that doesn't change. I just updated to documentation to how it's been done for quite some time now. |
flip1995
force-pushed
the
josh-docs-update
branch
from
cb4d505 to
89885c9
Compare
Based on #13693 Adds 2 subcommands to `cargo dev`: - `cargo dev sync update_nightly`: Which updates the nightly versions in `rust-toolchain` and `clippy_utils/README.md` - `cargo dev release bump_version`: Bumps the version in all relevant `Cargo.toml` files Those are pulled out of #12759, which I'll rebase on this. Next step is to update the documentation, which I'll partly pull out of #12762 r? @blyxyas (as you reviewed the first PR in the chain and were assigned to the second one) cc #13556 changelog: none
This updates the documentation after #13694. It is not based on that PR chain and can be merged independently, but should be merged after that PR. This is partly pulled from #12762, but removing the Josh parts. This includes instructions on how to publish `clippy_utils`. Closes #13556 (yes, this is the final PR 🙂) r? @blyxyas changelog: `clippy_utils` is now published to crates.io
|
☔ The latest upstream changes (presumably af1f78a) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm unassigning myself from this PR. @flip1995 if you want to continue this work, please request a new reviewer with |
This comment has been minimized.
This comment has been minimized.
Those were outdated anyway. Now with switching to Josh, the documentation should also be updated, as a lot of things got simplified. This updates the documentation on how to do syncs with josh, how to do releases and how to do backports.
flip1995
force-pushed
the
josh-docs-update
branch
from
89885c9 to
c7dec04
Compare
|
☔ The latest upstream changes (possibly f43f1d6) made this pull request unmergeable. Please resolve the merge conflicts. |
5 participants
Those were outdated anyway. Now with switching to Josh, the documentation should also be updated, as a lot of things got simplified. This updates the documentation on how to do syncs with josh, how to do releases and how to do backports.
r? @xFrednet
changelog: none