Document importing path-segment keyword #2136
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
traviscross
added
S-waiting-on-stabilization
As with other parts of the reference, the structure is moving more towards a set of rules, and the bullet list here isn't necessary.
This note was more of a general commentary on `self`, and was not specifically attached to its previous rule of items.use.self.namespace.
This is somewhat duplicated with the `self` section and the restrictions section which already describes about renaming.
This moves `$crate` to be next to `crate` since they are closely related.
This tries to simplify the wording and to maintain consistency, since they are all essentially saying the same thing.
The rules in the paths chapter don't entirely reflect what a valid path in a `use` declaration is. I'm not entirely sure what's the best approach for describing how paths work since there are several differences between `use` paths and expression paths.
Contributor
|
It looks like I don't have permission to push to this branch. I have pushed my edits to https://github.com/ehuss/reference/commits/doc/import-path-kw/. |
Author
@ehuss I have invited you :). Or I can merge your branch directly |
Contributor
Author
@traviscross Sadly, this seems to be only available for forks in personal accounts (link):
|
ehuss
force-pushed
the
doc/import-path-kw
branch
from
6243ecf to
ef94e6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to rust-lang/rust#146972