Skip to content

Add IP_MINTTL to bsd#5026

Merged
JohnTitor merged 1 commit intorust-lang:mainfrom
sungwoncho:add-ip-minttl-bsd
Mar 25, 2026
Merged

Add IP_MINTTL to bsd#5026
JohnTitor merged 1 commit intorust-lang:mainfrom
sungwoncho:add-ip-minttl-bsd

Conversation

@sungwoncho
Copy link
Contributor

@sungwoncho sungwoncho commented Mar 21, 2026

Description

Add IP_MINTTL to bsd.

Sources

Checklist

  • [y] Relevant tests in libc-test/semver have been updated
  • [y] No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • [n] Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

That command fails. But it also fails on latest HEAD (2aa834e). Is this checklist accurate?

root@freebsd-virt:/tmp/libc/libc-test # uname -a
FreeBSD freebsd-virt 15.0-RELEASE FreeBSD 15.0-RELEASE releng/15.0-n280995-7aedc8de6446 GENERIC amd64

root@freebsd-virt:/home/admin/libc/libc-test # cargo test --target x86_64-unknown-freebsd
...
error[E0609]: no field `mc_tlsbase` on type `libc::mcontext_t`
      --> /home/admin/libc/target/x86_64-unknown-freebsd/debug/build/libc-test-9eedd1f27e4e0a9f/out/ctest_output.rs:159915:50
       |
159915 |         let ty_ptr = unsafe { &raw const ((*bar).mc_tlsbase) };
       |                                                  ^^^^^^^^^^ unknown field
       |
help: a field with a similar name exists
       |
159915 -         let ty_ptr = unsafe { &raw const ((*bar).mc_tlsbase) };
159915 +         let ty_ptr = unsafe { &raw const ((*bar).mc_fsbase) };
       |

error[E0609]: no field `mc_tlsbase` on type `libc::mcontext_t`
      --> /home/admin/libc/target/x86_64-unknown-freebsd/debug/build/libc-test-9eedd1f27e4e0a9f/out/ctest_output.rs:159919:42
       |
159919 |         let off = offset_of!(mcontext_t, mc_tlsbase);
       |                                          ^^^^^^^^^^
       |
help: a field with a similar name exists
       |
159919 -         let off = offset_of!(mcontext_t, mc_tlsbase);
159919 +         let off = offset_of!(mcontext_t, mc_fsbase);
       |

Some errors have detailed explanations: E0282, E0412, E0425, E0609.
For more information about an error, try `rustc --explain E0282`.
error: could not compile `libc-test` (test "ctest") due to 108 previous errors

@sungwoncho
Copy link
Contributor Author

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 21, 2026
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnTitor JohnTitor added this pull request to the merge queue Mar 25, 2026
@JohnTitor
Copy link
Member

That command fails. But it also fails on latest HEAD (2aa834e). Is this checklist accurate?

That's because you use different versions of toolchains than CI (a container env from CI scripts). It's fine as long as CI passes.

Merged via the queue into rust-lang:main with commit 34527ca Mar 25, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants