Fix locale values and add RTLD_NOLOAD, and some TCP constants for Redox OS#5025
Draft
ChihweiLHBird wants to merge 2 commits intorust-lang:mainfrom
Draft
Fix locale values and add RTLD_NOLOAD, and some TCP constants for Redox OS#5025ChihweiLHBird wants to merge 2 commits intorust-lang:mainfrom
ChihweiLHBird wants to merge 2 commits intorust-lang:mainfrom
Conversation
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
LC_*locale constants, original values were copied from Linux, but Redox'srelibcuses a different numbering (LC_ALL=6instead of 0)RTLD_NOLOADfromdlfcn.hTCP_MAXSEG,TCP_KEEPINTVL,TCP_KEEPCNTfromnetinet/tcp.hSources
RTLD_NOLOADLC_COLLATEthroughLC_ALLTCP_MAXSEG,TCP_KEEPINTVL,TCP_KEEPCNTChecklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI