feat(anstream): Provide read-only access to inner stream #275
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main concern we have is `&mut Inner` because our processing of input is stateful and this can mess things up. Adding an `as_inner` doesn't have that problem and can be useful for any custom behavior users have added that they want to query. This particularly came up with converting Rustup from termcolor to anstream because of their test stream.
Pull Request Test Coverage Report for Build 18200016261Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main concern we have is
&mut Innerbecause our processing of input is stateful and this can mess things up.Adding an
as_innerdoesn't have that problem and can be useful for any custom behavior users have added that they want to query. This particularly came up with converting Rustup from termcolor to anstream because of their test stream.