Upgrade to soon-to-be-released `bitcoin` by tcharding · Pull Request #528 · rust-bitcoin/corepc

tcharding · 2026-03-04T03:10:56Z

Upgrade to the upcoming bitcoin beta release (master branch of bitcoin with a few PRs merged in: #5704, #5657, and #5710).

Expect all red in CI. Locally, with the bitcoin branch available, I can run the integration tests (with test17 and test29).

jamillambert

I assume the first patch ignoring the .claude folder is for your local dev only and you didn't want to use a global ignore.

I couldn't find the branch on your rust-bitcoin fork that you were using. I used instead the current master with the PRs you listed added. But then I had to change HeaderDecoderError and TransactionDecoderError to be wrapped in DecodeError.

After I did that it builds and the tests all pass. Besides the points below it all looks good.

jamillambert · 2026-03-05T15:45:50Z

types/src/model/blockchain.rs

    pub average_fee: Amount,
    /// Average feerate.
-    pub average_fee_rate: Option<FeeRate>,
+    pub average_fee_rate: FeeRate,


This field and some of the others changed are optional in v25. Why the removal of Option?

Edit: I realised it was removed due to the change in the return type in rust-bitcoin. But it highlights an existing error that it, in fact all fields in the v25 GetBlockStats are optional. Opened #530

jamillambert · 2026-03-05T15:50:11Z

types/src/model/blockchain.rs

 /// Models the result of JSON-RPC method `getblockstats`.
-#[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
+// #[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
+// FIMXE: How do we serde a `Vec<FeeRate>`?


AI says you can use a helper and gave the below, it is possible to use the existing bitcoin::fee_rate::serde::as_sat_per_vb_floor but still needs a helper for the vec.

mod fee_rate_vec_serde { use bitcoin::FeeRate; use serde::{Deserialize, Deserializer, Serialize, Serializer}; pub fn serialize<S>(rates: &Vec<FeeRate>, serializer: S) -> Result<S::Ok, S::Error> where S: Serializer, { let sats: Vec<u64> = rates.iter().map(|rate| rate.to_sat_per_vb_floor()).collect(); sats.serialize(serializer) } pub fn deserialize<'de, D>(deserializer: D) -> Result<Vec<FeeRate>, D::Error> where D: Deserializer<'de>, { let sats = Vec::<u32>::deserialize(deserializer)?; Ok(sats.into_iter().map(FeeRate::from_sat_per_vb).collect()) } }

Oh yes, I didn't know that at the time I wrote the comment. I actually added this sort of thing in rust-bitcoin/rust-bitcoin#5704

I'm not sure if we should push Vec support upstream for all the types that currently have serde support as modules (ie Amount). Or just hack it in here?

I think it makes more sense to have them upstream, I don't see the downside and it then enables it for everyone.

Opened: rust-bitcoin/rust-bitcoin#5786

jamillambert · 2026-03-05T16:02:40Z

types/src/v24/raw_transactions/mod.rs

+        let bytes = bitcoin::hex::decode_to_vec(sig).map_err(E::Hex)?;
        let (sighash_byte, signature) = bytes.split_last().ok_or(E::EmptySignature)?;
        Ok(Signature {
            signature: secp256k1::schnorr::Signature::from_slice(signature)


Lint warning:
warning: use of deprecated associated function `bitcoin::secp256k1::schnorr::Signature::from_slice`: Use `from_byte_array` instead

Yeah this is non-trivial to remove so I just left it in for now.

jamillambert · 2026-03-05T16:03:25Z

types/src/v30/raw_transactions/mod.rs

+        let bytes = bitcoin::hex::decode_to_vec(sig).map_err(E::Hex)?;
        let (sighash_byte, signature) = bytes.split_last().ok_or(E::EmptySignature)?;
        Ok(Signature {
            signature: secp256k1::schnorr::Signature::from_slice(signature)


Lint warning:
warning: use of deprecated associated function `bitcoin::secp256k1::schnorr::Signature::from_slice`: Use `from_byte_array` instead

jamillambert · 2026-03-05T16:05:37Z

types/src/v17/blockchain/into.rs

-            average_fee: Amount::from_sat(self.average_fee),
-            average_fee_rate,
+            average_fee: Amount::from_sat(self.average_fee).expect("TODO: Handle this error"),
+            average_fee_rate: average_fee_rate,


Suggested change

average_fee_rate: average_fee_rate,

average_fee_rate,

Was this change left over from a previous revision? there is no need for it.

Not sure, thanks man. I wasn't expecting such a thorough review. Appreciate it!

jamillambert · 2026-03-05T16:41:24Z

types/src/v30/hidden/error.rs

@@ -0,0 +1,72 @@
+// SPDX-License-Identifier: CC0-1.0


This file was removed intentionally on master.

tcharding · 2026-03-05T21:50:38Z

I assume the first patch ignoring the .claude folder is for your local dev only and you didn't want to use a global ignore.

Oh that is sloppy of me, will remove.

I couldn't find the branch on your rust-bitcoin fork that you were using. I used instead the current master with the PRs you listed added. But then I had to change HeaderDecoderError and TransactionDecoderError to be wrapped in DecodeError.

After I did that it builds and the tests all pass. Besides the points below it all looks good.

My bad, I never pushed the branch. I only added the three PRs and didn't have to touch the decoder errors from memory. I"ll investigate. Thanks for going to the trouble of building this, I did not expect that. Pleasant surprise.

Upgrade to the upcoming bitcoin beta release. This is a local branch with a few PRs merged as described in rust-bitcoin/rust-bitcoin#5742

Ignore the claude config directory

2607a0b

tcharding requested a review from jamillambert as a code owner March 4, 2026 03:10

tcharding marked this pull request as draft March 4, 2026 03:11

github-actions bot added C-client C-integration-test C-types labels Mar 4, 2026

tcharding changed the title ~~Upgrade bitcoin dependency~~ Upgrade to bitcoin-0.33.0-beta++ dependency Mar 4, 2026

tcharding changed the title ~~Upgrade to bitcoin-0.33.0-beta++ dependency~~ Upgrade to soon-to-be-released bitcoin Mar 4, 2026

tcharding mentioned this pull request Mar 4, 2026

Do next RC release rust-bitcoin/rust-bitcoin#5742

Open

jamillambert reviewed Mar 5, 2026

View reviewed changes

Upgrade bitcoin dependency

89590da

Upgrade to the upcoming bitcoin beta release. This is a local branch with a few PRs merged as described in rust-bitcoin/rust-bitcoin#5742

tcharding force-pushed the push-ttwqxqrtktxl branch from 7b66711 to 89590da Compare March 10, 2026 00:26

tcharding mentioned this pull request Mar 10, 2026

Upgrade bitcoin to the upcoming 0.32.0-rc.0 release rust-bitcoin/rust-miniscript#874

Open

Conversation

tcharding commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamillambert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tcharding commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tcharding commented Mar 4, 2026 •

edited

Loading