test: that 2nd protocol.write() to closed socket fails
#164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the sync variant of 0719bcc. While this works at the moment, I think it's good to have this test for extra coverage. It can also be easily extended in a follow up to test sync write() on a closed socket (see rust-bitcoin#160 (comment)).
As TCP is buffered and asynchronous at the OS level, the first protocol.write() to a closed socket can succeed for both sync and async. The second write will fail. As this confused me in rust-bitcoin#161, and I assumed it's a bug, document this here by having test coverage for it. closes rust-bitcoin#161
Contributor
Author
|
Draft as the first commit is from #163. Will rebase once that's merged. Also, I don't think having this is super important. Feel free to close if you'd rather not have it. |
Contributor
Author
Well.. at least on Linux I guess. Not on Windows? |
Contributor
Author
|
Going to close this. I did a few runs in https://github.com/0xB10C/bip324/actions/runs/20881650088?pr=4 and this seems brittle. I don't think it's important enough at the moment. Just be aware that writing to a socket and getting Ok() might not mean that socket is still alive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As TCP is buffered and asynchronous at the OS level, the first
protocol.write()to a closed socket can succeed for both sync and async. The second write will fail.As this confused me in #161, and I assumed it's a bug, document this here by having test coverage for it.
closes #161