Remove bitcoin for secp256k1
#156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help with type safety a bit, I have public callsites use an `impl Borrow<[u8; 4]>`, which the `p2p::Magic` type implements. This way one can pass magic variables directly. In the handshake this just gets dereferenced anyway, but it still feels more ergonomic than forcing a `to_bytes` on the caller IMO. I keep the `secp256k1` the same, but maybe it can be bumped. I forget if there are problems when attempting to build conflicting versions or not.
Collaborator
|
Dope, looks clean to me. I think the failures are legit, as far as we might just have to tweak the docs if its too annoying to get |
Collaborator
Author
|
Going to clean it up next week, but in the meantime, any idea of what the no_std error is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with type safety a bit, I have public callsites use an
impl Borrow<[u8; 4]>, which thep2p::Magictype implements. This way one can pass magic variables directly. In the handshake this just gets dereferenced anyway, but it still feels more ergonomic than forcing ato_byteson the caller IMO.I keep the
secp256k1the same, but maybe it can be bumped. I forget if there are problems when attempting to build conflicting versions or not.