Add blankIfUnexpanded with true value by default#22
Open
avelasquezr wants to merge 1 commit intorundeck-plugins:masterfrom
Open
Add blankIfUnexpanded with true value by default#22avelasquezr wants to merge 1 commit intorundeck-plugins:masterfrom
avelasquezr wants to merge 1 commit intorundeck-plugins:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fixes compatibility issues with the Nixy plugin between Rundeck versions 4.8 and 4.14+ by adding the blankIfUnexpanded: true property to script configuration fields to prevent job failures when unexpanded variables are present.
- Adds
blankIfUnexpanded: trueto script configuration properties - Ensures backward compatibility for jobs using the Nixy plugin
- Maintains expected behavior across Rundeck version upgrades
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Bug:
Jobs using nixy that were worked on 4.8 stopped working properly on 4.14.x and 4.15.x
My Rundeck detail
Rundeck version: [ 4.8.0 , 4.14 ]
install type: [ deb, war ]
OS Name/version: [ ubuntu 20, ubuntu 22, macOs, windows]
DB Type/version: [ Mariadb, H2 ]
To Reproduce
Steps to reproduce the behavior:
1- Install rundeck 4.8 and upload the yaml that I leave here.
2- Run that job and you will see that the output is ok
3- Install rundeck 4.14 and do the same
4- You will see that the jobs failed
Expected behavior
We expected that the Nixy plugin works fine on both versions.
Solution
The field
blankIfUnexpandedis added as true by default.