feat(job-wait): Fix IndexError and add ApiException for better error handling#155
Open
haracejacob wants to merge 1 commit intorundeck-plugins:masterfrom
Open
feat(job-wait): Fix IndexError and add ApiException for better error handling#155haracejacob wants to merge 1 commit intorundeck-plugins:masterfrom
haracejacob wants to merge 1 commit intorundeck-plugins:masterfrom
Conversation
|
This issue still occurs, whe solved it by mannualy patching job-wait.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
job-waitis executed immediately afterjob-create, thecore_v1.list_namespaced_pod()function sometimes returns an empty array, it cause an IndexError when accessingpod_list.items[0]. This is due to the delay between job creation and pod creation.To fix this issue, Throwing
ApiException(404)when an empty array is returned to executetime.sleep(). And it raiseTimeoutErrorin an error situation.AS-IS
TO-BE