Add what's needed to make probes work with normal cron#482
Merged
ericvaandering merged 1 commit intomasterfrom Feb 6, 2026
Merged
Add what's needed to make probes work with normal cron#482ericvaandering merged 1 commit intomasterfrom
ericvaandering merged 1 commit intomasterfrom
Conversation
rdimaio
reviewed
Feb 5, 2026
Contributor
rdimaio
left a comment
rdimaio
left a comment
There was a problem hiding this comment.
Copilot raised some issues, but indeed if this is only being used by CMS and you tested that it works then it should be fine to merge; could you confirm that this works in CMS?
Contributor
Author
|
Yes. It works fine. I may take some of the co-pilot suggestions |
rdimaio
approved these changes
Feb 6, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ericvaandering
force-pushed
the
481-make-an-option-for-cron-based-probes
branch
from
94c9ff1 to
63551f3
Compare
ericvaandering
force-pushed
the
481-make-an-option-for-cron-based-probes
branch
from
63551f3 to
ffe7415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm told no one else uses this container, so it should be OK to merge. But comments welcome on the PR regardless.