Skip to content

Prevent tests from modifying user's global git config #9397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsbt wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −0
Open

Prevent tests from modifying user's global git config #9397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9a921b
Prevent tests from modifying user's global git config
hsbt Mar 16, 2026
d157405
Add git version filter for spec metadata
hsbt Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions bundler/spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,14 @@ def self.ruby=(ruby)
ENV["XDG_CACHE_HOME"] = nil
ENV["GEMRC"] = nil

# Prevent tests from modifying the user's global git config.
# GIT_CONFIG_GLOBAL and GIT_CONFIG_NOSYSTEM are available since Git 2.32.
git_version = `git --version`[/(\d+\.\d+\.\d+)/, 1]
if Gem::Version.new(git_version) >= Gem::Version.new("2.32")
Comment on lines +133 to +134
ENV["GIT_CONFIG_GLOBAL"] = File.join(ENV["HOME"], ".gitconfig")
ENV["GIT_CONFIG_NOSYSTEM"] = "1"
end

# Don't wrap output in tests
ENV["THOR_COLUMNS"] = "10000"

Expand Down
3 changes: 3 additions & 0 deletions bundler/spec/support/filters.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@ def inspect
end
end

git_version = Gem::Version.new(`git --version`[/(\d+\.\d+\.\d+)/, 1])

Comment on lines +21 to +22
RSpec.configure do |config|
config.filter_run_excluding realworld: true

config.filter_run_excluding rubygems: RequirementChecker.against(Gem.rubygems_version)
config.filter_run_excluding git: RequirementChecker.against(git_version)
config.filter_run_excluding ruby_repo: !ENV["GEM_COMMAND"].nil?
config.filter_run_excluding no_color_tty: Gem.win_platform? || !ENV["GITHUB_ACTION"].nil?
config.filter_run_excluding permissions: Gem.win_platform?
Expand Down
Loading