-
Notifications
You must be signed in to change notification settings - Fork 43
Upgrading to GStreamer 1.0 and makefile improvements #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reiniert
wants to merge
18
commits into
rticommunity:master
Choose a base branch
from
reiniert:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved makefiles
Corrected launch scripts
…r Micro. The resulting executables have been tested with Pro, not yet with Micro.
Added looping of video
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rosemwahlin and @jpovedano, please review the changes.
Disclaimers:
Changes to code:
-- One particular change to be aware of is that the "ffmpegcolorspace" plugin is no longer supported. The pipeline had to be modified to use "videoconvert" instead
-- In particular, the re-defintion of the restrict macro was an issue, I changed it to use the same solution as GStreamer has for this, found in the file gst/gstmacros.h. When compiling with C++, STDC_VERSION is not defined, but restrict is supported (although called restrict for some compiler versions).
-- The Darwin version works but has an issue with the GStreamer display on the receiving side. I do not know yet how to resolve that, I think the pipeline is incorrect. I was able to send video date from OSX and receive and display on Ubuntu.
Changes to the run scripts:
-- I did remove the reference to the thirdparty libraries because it is not clear to me whether we really need those? For both Ubuntu and Darwin, I was fine without them -- are these for Windows only?
Changes to build system:
-- If you agree that this is important, I could review the makefiles for the other use cases and make similar adjustments -- let me know
List of makefile problems resolved: