Changes for HA support #4
Conversation
|
I'm not particularly happy with the merging and patches c467190 and 0e43f62. It looks like you took your older branch, merged the newer branch in, then continued work. This is unnecessary; just base your newer patches on the 'ha' branch. If there is actually problem in the github/routeflow/ha branch, please create a patch to fix it. The later patches can then be rebased on top. I would expect the history to look like: EDIT: You can see clearly what I mean at the network graph: https://github.com/routeflow/ryu-rfproxy/network From vandervecken, there is the routeflow/ha branch with two patches. |
To register controller with RFMonitor, send a ControllerRegister message to RFMonitor. The message has controller listening host, port and role. Signed-off-by: Srijan Mishra <[email protected]>
A controller was being registered with RFMonitor when ryu app was initialized. Thus, it was not possible to keep a track on how many devices a controller is connected to. Now the registration is done when a device comes up. This helps in keeping exact count of devices to which a controller is connected to. Signed-off-by: Srijan Mishra <[email protected]>
RFMonitor informs rfproxy about the new master elected by ELECT_MASTER message. The message is parsed at rfproxy and all the devices are informed about the new master. Signed-off-by: Srijan Mishra <[email protected]>
|
I have rebased my branch to have commits as you mentioned. EDIT: The rebasing has changed the commit sha but the commits are same. Will it be a problem? |
The controller address is stored on CONF.ofp_listen_host config variable provided by ryu API. If the parameter is not provided run time then the controller is listens on localhost and the value of this variable is uninitialized. So a check is made on init on variable and in case its empty it is assigned value '127.0.0.1'. Signed-off-by: Srijan Mishra <[email protected]> Acked-by: Joe Stringer <[email protected]>
The arguments that were being passed into register_controller function are available with the class object and the config variable for the ryu app. The function definition is changed and correct calling of function where it is being invoked. Signed-off-by: Srijan Mishra <[email protected]>
|
The fact that GitHub loses the original comments is why I like the idea of making a fresh pull request each time you address feedback and change the tree. You can see why now :-) Overall these changes look fine to me. |
|
It looks like this pull request is superceded by #5. Closing. |
2 participants
The pull request has all the changes required for HA support in rfproxy.
The changes include processing of new master election message sent by RFMonitor and inform about the newly elected master to all the devices connected.