Add Rubocop rule to catch arrays of size > 300. Also fix a bunch of .rubocop_todo.yml#2256
Open
Add Rubocop rule to catch arrays of size > 300. Also fix a bunch of .rubocop_todo.yml#2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a custom cop to deal with huge array literals not in lazily-loaded files. I will be going through the todo file and fixing these in the next few weeks.
Also disables the following Rubocop rules:
Lint/OutOfRangeRegexpRefis just broken as far as I can tell, it is catching perfectly valid uses of these refs.Lint/MissingSuperis just not helpful most of the time in this projectLint/ToEnumArgumentsis not able to tell when arguments are deprecated, and is therefore not actionable and just noiseLint/NextedPercentLiteralis full of false-positives on account of the strange string literals we have to deal with in this projectLint/DuplicateBranchafter fixing a number of these (though I included the fixes) I concluded that most instances caught were not actually problems.Naming/MethodParameterNameencourages huge variable names when small ones will doNaming/HeredocDelimiterNamingis useless and annoyingNaming/VariableNumberis very opinionated on a very strange opinion